Description
SiYuan before v3.8.4 does not HTML-escape stored flashcard block content before interpolating it into the card-manager list markup. Block content returned by /api/riff/getRiffCards is inserted into a card item template in app/src/card/viewCards.ts and assigned to listElement.innerHTML, so content such as <img src=invalid onerror=...> becomes an executable event-handler attribute. Because the SiYuan desktop (Electron) main window is created with nodeIntegration enabled and contextIsolation disabled, an administrator who opens the card manager on a workspace containing attacker-supplied flashcard content (for example introduced through contribution or import) executes the attacker's script in a privileged renderer, which can lead to arbitrary code execution on the host. The affected endpoint remains behind authentication and administrator-role checks; this is an untrusted-content-to-privileged-renderer issue, not an authorization bypass.
References7
- github.com/siyuan-note/siyuan/commit/1ecb1c07de497ff03b585536fe…
- github.com/siyuan-note/siyuan/commit/41b14025b4ac4a8379d1200580…
- github.com/siyuan-note/siyuan/commit/48c354e7de130aaada9d712012…
- github.com/siyuan-note/siyuan/commit/8641553a1f07374001902d3ce7…
- github.com/siyuan-note/siyuan/security/advisories/GHSA-2mmf-4xw…
- www.vulncheck.com/advisories/siyuan-before-3.8.4-stored-xss-via…
- github.com/siyuan-note/siyuan/security/advisories/GHSA-2mmf-4xw…
Metrics
- CVSS 3.1
-
8.0
HIGH
Score source: CNA
CVSS:3.1/AV:N/AC:L/PR:L/UI:R/S:U/C:H/I:H/A:H - CVSS 4.0
-
8.6
HIGH
Score source: CNA
CVSS:4.0/AV:N/AC:L/AT:N/PR:L/UI:P/VC:H/VI:H/VA:H/SC:N/SI:N/SA:N/E:X/CR:X/IR:X/AR:X/MAV:X/MAC:X/MAT:X/MPR:X/MUI:X/MVC:X/MVI:X/MVA:X/MSC:X/MSI:X/MSA:X/S:X/AU:X/R:X/V:X/RE:X/U:X - EPSS — exploit probability
- 1% percentile: 52 · as of 9 November 2026
- CWE
- CWE-79
Could this be exploited in your environment?
A patch closes the known hole. A penetration test shows what an attacker can still reach — with proof.